Bsr bump spectree #7617
Merged
Bsr bump spectree #7617
+254
−267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lixxday
force-pushed
the
bsr-bump-spectree
branch
from
a8ede8a
to
8f2af86
Compare
lixxday
force-pushed
the
bsr-bump-spectree
branch
from
29a27e9
to
fcfaa9c
Compare
lixxday
commented
Aug 9, 2023
dbaty
reviewed
Aug 9, 2023
dbaty
reviewed
Aug 9, 2023
lixxday
force-pushed
the
bsr-bump-spectree
branch
2 times, most recently
from
add347d
to
73d7b84
Compare
dbaty
approved these changes
Aug 10, 2023
lixxday
force-pushed
the
bsr-bump-spectree
branch
2 times, most recently
from
fc0d003
to
2c1f26b
Compare
I checked, the operationId is not used by the frontend, this is not a breaking change for us
What's new: - spectree now handles form in requests - spectree considers empty body as not json. Therefore I added a header to tell spectree validators to expect json if body is None
Our implementation of generate_spec is basically the same as the one in the lib cf. https://github.com/0b01001001/spectree/blob/98f2e1d522c291165b2a6233416c26a224f2750b/spectree/response.py#L124
Can't believe it works!
I specifically commit that separately because I am not 100% confident this actually tests the same thing
lixxday
force-pushed
the
bsr-bump-spectree
branch
from
2c1f26b
to
a666f12
Compare
|
Visit the preview URL for this PR (updated for commit 33308e8): https://pc-pro-testing--pr7617-bsr-bump-spectree-6lkuek4v.web.app (expires Wed, 16 Aug 2023 15:51:39 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 032d233ee67e1c50d6af12e29c936c7076770eb1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
But de la pull request
Bump spectree
En effet, selon leur doc, pydantic v2 est supporté seulement à partir de la 1.2
Et on veut pydantic v2
Changelog de SpecTree: https://github.com/0b01001001/spectree/releases
Ticket Jira (ou description si BSR) : PC-23699
Vérifications